telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py - Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py ('K') | « telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py ('k') | telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py » ('j') | telemetry/telemetry/value/trace.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

diff --git a/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py b/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

index 8fe1c4571e814343efd78e077b05b25ad491a723..3e06bfe31ae7141c10d9f5fcd6c73467371d751c 100644

--- a/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

+++ b/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

@@ -169,9 +169,9 @@ class BattOrTracingAgentTest(unittest.TestCase):

self.android_agent.CollectAgentTraceData(builder)

self.assertTrue(self.android_agent._battor._collect_trace_data_called)

builder = builder.AsData()

- self.assertTrue(builder.HasTraceFor(trace_data.BATTOR_TRACE_PART))

- data_from_builder = builder.GetTraceFor(trace_data.BATTOR_TRACE_PART)

- self.assertEqual(_BATTOR_RETURN, data_from_builder)

+ self.assertTrue(builder.HasTracesFor(trace_data.BATTOR_TRACE_PART))

+ data_from_builder = builder.GetTracesFor(trace_data.BATTOR_TRACE_PART)

+ self.assertEqual([_BATTOR_RETURN], data_from_builder)

def testAndroidCharging(self):

self.assertTrue(self.android_agent._battery.GetCharging())