telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py - Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/core/tracing_controller_unittest.py ('k') | telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py » ('j') | telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

index 4856c6bd5e202acf56330b392e275a762f56b2c6..dc24172fcf48ba33e88487caf69f378257404b4b 100644

--- a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

@@ -362,9 +362,8 @@ class DevToolsClientBackend(object):

def CollectChromeTracingData(self, trace_data_builder, timeout=30):

try:

- for tab_id in self._tab_ids:

- trace_data_builder.AddEventsTo(

- trace_data_module.TAB_ID_PART, [tab_id])

+ trace_data_builder.AddTraceFor(

+ trace_data_module.TAB_ID_PART, self._tab_ids[:])

self._tab_ids = None

finally:

self._tracing_backend.CollectTraceData(trace_data_builder, timeout)