Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5245)

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 2619063003: Update viewport_meta setting on any navigation. (Closed)
Patch Set: Another EXPECT_EQ -> EXPECT_FALSE Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl_unittest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc
index 637dec0f089c37aad8fda36efb43f1713dc2a85f..56486ee9ac3c4ec2b7c90ae0420ceca4d623b584 100644
--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc
@@ -1647,6 +1647,48 @@ TEST_F(NavigationControllerTest, RedirectsAreNotResetByCommit) {
EXPECT_EQ(url2, committed_entry->GetRedirectChain()[0]);
}
+// Tests that webkit preferences are updated when user agent override changes.
+TEST_F(NavigationControllerTest, GoBackWithUserAgentOverrideChange) {
+ NavigationControllerImpl& controller = controller_impl();
+
+ // Set up a simple NavigationEntry stack of two pages.
+ const GURL url1("http://foo/1");
+ const GURL url2("http://foo/2");
+
+ controller.LoadURL(url1, Referrer(), ui::PAGE_TRANSITION_TYPED,
+ std::string());
+ int entry_id = controller.GetPendingEntry()->GetUniqueID();
+ EXPECT_FALSE(controller.GetPendingEntry()->GetIsOverridingUserAgent());
+ main_test_rfh()->PrepareForCommit();
+ main_test_rfh()->SendNavigate(entry_id, true, url1);
+
+ controller.LoadURL(url2, Referrer(), ui::PAGE_TRANSITION_TYPED,
+ std::string());
+ entry_id = controller.GetPendingEntry()->GetUniqueID();
+ EXPECT_FALSE(controller.GetPendingEntry()->GetIsOverridingUserAgent());
+ main_test_rfh()->PrepareForCommit();
+ main_test_rfh()->SendNavigate(entry_id, true, url2);
+
+ // Simulate the behavior of "Request Desktop Site" being checked in
+ // NavigationControllerAndroid::SetUseDesktopUserAgent.
+ controller.GetVisibleEntry()->SetIsOverridingUserAgent(true);
+ controller.Reload(ReloadType::ORIGINAL_REQUEST_URL, true);
+ EXPECT_TRUE(controller.GetLastCommittedEntry()->GetIsOverridingUserAgent());
+
+ // Test that OnWebkitPreferencesChanged is called when going back to propagate
+ // change in viewport_meta WebSetting.
+ int change_counter = 0;
+ test_rvh()->set_webkit_preferences_changed_counter(&change_counter);
+
+ controller.GoBack();
+ entry_id = controller.GetPendingEntry()->GetUniqueID();
+ EXPECT_FALSE(controller.GetPendingEntry()->GetIsOverridingUserAgent());
+ main_test_rfh()->PrepareForCommit();
+ main_test_rfh()->SendNavigate(entry_id, false, url1);
+
+ EXPECT_EQ(1, change_counter);
+}
+
// Tests what happens when we navigate back successfully
TEST_F(NavigationControllerTest, Back) {
NavigationControllerImpl& controller = controller_impl();
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698