Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2619053002: Run 'Inline Method' refactoring tests with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run 'Inline Method' refactoring tests with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/188c0870365438c0e72ff224a5f678870ef12031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -15 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 7 chunks +41 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 8 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-06 21:22:14 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-06 21:47:14 UTC) #2
scheglov
3 years, 11 months ago (2017-01-06 21:51:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
188c0870365438c0e72ff224a5f678870ef12031 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698