Issue 261903002: Generation of our home-grown memmove doesn't depend on serializer state anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 261903002: Generation of our home-grown memmove doesn't depend on serializer state anymore. (Closed)

Created:
6 years, 7 months ago by Sven Panne

Modified:
6 years, 7 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generation of our home-grown memmove doesn't depend on serializer state anymore. The serializer state has to be per-Isolate, but at the point where we generate our memmoves we don't really have an Isolate. Furthermore, there was no fundamental reason why we shouldn't use our home-grown memmove during mksnapshot time. Perhaps we can totally remove our own memmove nowadays, but this would be a separate CL. BUG=359977 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21116

Patch Set 1 #

Patch Set 2 : Removed parameter. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -22 lines)			Patch
M	src/arm/codegen-arm.cc	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/mips/codegen-mips.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/platform.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-posix.cc	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	src/platform-win32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 7 months ago (2014-05-02 10:14:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21116 (presubmit successful).

Expand Messages | Collapse Messages