Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2619013003: Implement search for LibraryElement in its parts. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement search for LibraryElement in its parts. It's not the most efficient implementation though. Probably does not matter, search for libraries should be very rare. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/05963058d263e2cf6133d98e82d83f45b2b4af53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/search.dart View 2 chunks +30 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/search_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-06 19:54:23 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-06 19:55:25 UTC) #2
scheglov
3 years, 11 months ago (2017-01-06 20:12:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
05963058d263e2cf6133d98e82d83f45b2b4af53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698