Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/heapcheck/chrome_tests.py

Issue 26190002: Add --target flag to the chrome_tests.py scripts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/chrome_tests.py » ('j') | tools/valgrind/chrome_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/heapcheck/chrome_tests.py
diff --git a/tools/heapcheck/chrome_tests.py b/tools/heapcheck/chrome_tests.py
index c96adc9bd7408bfdcdfb69255ceb5411448249cb..cfc662a11cad1e3259563b79e6c3fb538ea3f07f 100755
--- a/tools/heapcheck/chrome_tests.py
+++ b/tools/heapcheck/chrome_tests.py
@@ -475,12 +475,11 @@ def main():
# TODO(thakis): Remove --build_dir once bots don't pass it.
"--build_dir",
help="the location of the output of the compiler output")
- parser.add_option("-t", "--test", action="append",
- help="which test to run")
- parser.add_option("", "--gtest_filter",
+ parser.add_option("--target", help="Debug or Release")
+ parser.add_option("-t", "--test", action="append", help="which test to run")
+ parser.add_option("--gtest_filter",
help="additional arguments to --gtest_filter")
- parser.add_option("", "--gtest_repeat",
- help="argument for --gtest_repeat")
+ parser.add_option("--gtest_repeat", help="argument for --gtest_repeat")
parser.add_option("-v", "--verbose", action="store_true", default=False,
help="verbose output - enable debug log messages")
# My machine can do about 120 layout tests/hour in release mode.
@@ -492,6 +491,12 @@ def main():
options, args = parser.parse_args()
+ # target used to be a part of build_dir, so only add it if it's not there.
+ # TODO(thakis): Always do this once the memory master no longer passes
+ # the target as part of build_dir.
+ if options.target and options.target not in options.build_dir:
+ options.build_dir = os.path.join(options.build_dir, options.target)
+
if options.verbose:
logging_utils.config_root(logging.DEBUG)
else:
« no previous file with comments | « no previous file | tools/valgrind/chrome_tests.py » ('j') | tools/valgrind/chrome_tests.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698