Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_local_test.dart

Issue 2618993003: Run refactoring tests with the new analysis driver. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_local_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_local_test.dart b/pkg/analysis_server/test/services/refactoring/rename_local_test.dart
index 4fe584ed80c5e9b3c4f40fe64807c975e6d2df2b..a364817932eefa28fdc47606fb34d4f29ebd3ba7 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_local_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_local_test.dart
@@ -14,6 +14,7 @@ import 'abstract_rename.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(RenameLocalTest);
+ defineReflectiveTests(RenameLocalTest_Driver);
});
}
@@ -165,17 +166,17 @@ class A {
test_checkFinalConditions_shadows_classMember_namedParameter() async {
await indexTestUnit('''
class A {
- foo({test: 1}) {
+ foo({test: 1}) { // in A
}
}
class B extends A {
var newName = 1;
- foo({test: 2}) {
+ foo({test: 1}) {
print(newName);
}
}
''');
- createRenameRefactoringAtString('test: 1}');
+ createRenameRefactoringAtString('test: 1}) { // in A');
// check status
refactoring.newName = 'newName';
RefactoringStatus status = await refactoring.checkFinalConditions();
@@ -234,10 +235,10 @@ main() {
test_checkNewName_FunctionElement() async {
await indexTestUnit('''
main() {
- int test() {}
+ int test() => 0;
}
''');
- createRenameRefactoringAtString('test() {}');
+ createRenameRefactoringAtString('test() => 0;');
// null
refactoring.newName = null;
assertRefactoringStatus(
@@ -553,3 +554,21 @@ main() {
expect(refactoring.oldName, 'test');
}
}
+
+@reflectiveTest
+class RenameLocalTest_Driver extends RenameLocalTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+
+ @failingTest
+ @override
+ test_createChange_parameter_named_inOtherFile() {
+ return test_createChange_parameter_named_inOtherFile();
+ }
+
+ @failingTest
+ @override
+ test_createChange_parameter_named_updateHierarchy() {
+ return test_createChange_parameter_named_updateHierarchy();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698