Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2618993003: Run refactoring tests with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run refactoring tests with the new analysis driver. There are some failures because of missing potential search results. These tests are not updated yet because they have too many problems now. inline_method_test.dart move_file_test.dart rename_import_test.dart rename_library_test.dart R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/31c7cce275f11a53a50842d1fb5b51175c7c6445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -26 lines) Patch
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 3 chunks +16 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 6 chunks +11 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 10 chunks +15 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 2 chunks +43 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 4 chunks +24 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-06 18:42:40 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-06 18:47:00 UTC) #2
scheglov
3 years, 11 months ago (2017-01-06 18:49:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31c7cce275f11a53a50842d1fb5b51175c7c6445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698