Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2618983003: Remove code duplication (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -404 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 1 chunk +4 lines, -135 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 2 chunks +3 lines, -134 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 11 chunks +16 lines, -135 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/dart/utilities.dart View 1 chunk +152 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 11 months ago (2017-01-06 18:45:43 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-06 18:46:58 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-06 18:56:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07895169be0d4363046554239c7097d0ee149338 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698