Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2618923003: Update 'Add final field formal parameters' Quick Fix to support the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update 'Add final field formal parameters' Quick Fix to support the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0377beb1286ff8dc3a1e79ec91cbf6b68eea6fc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -60 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +23 lines, -25 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/error/error.dart View 3 chunks +1 line, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +42 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-06 22:30:33 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-06 22:33:34 UTC) #2
scheglov
3 years, 11 months ago (2017-01-06 22:34:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0377beb1286ff8dc3a1e79ec91cbf6b68eea6fc6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698