Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore (Closed)
Patch Set: try skipping UMA for test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
index 073147059a8ed649918b63bee512cfe476f0b4c0..0a2486f07b78361ac336f9293130199d36a809f5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
@@ -9,6 +9,7 @@
import org.chromium.base.Callback;
import org.chromium.chrome.browser.ntp.cards.SuggestionsCategoryInfo;
import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;
+import org.chromium.chrome.browser.suggestions.SuggestionsUma;
import java.util.List;
@@ -98,7 +99,9 @@
void restoreDismissedCategories();
/**
- * Sets the recipient for update events from the source.
+ * Finishes initialisation of the suggestions source, pairing it with an observer.
+ * @param observer object to notify when snippets are received.
+ * @param umaHelper object used to obtain metrics-related data.
*/
- void setObserver(Observer observer);
+ void init(Observer observer, SuggestionsUma umaHelper);
}

Powered by Google App Engine
This is Rietveld 408576698