Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore (Closed)
Patch Set: rebase, address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java
index 8ca0ed49cf9509449895664db7957dc4dec69b4a..0d66ebc7e2ab0eb9803884f2bc64692e55db5bb2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java
@@ -94,23 +94,7 @@ public void navigateToRecentTabs() {}
public void navigateToDownloadManager() {}
@Override
- public void trackSnippetsPageImpression(int[] categories, int[] suggestionsPerCategory) {}
-
- @Override
- public void trackSnippetImpression(SnippetArticle article) {}
-
- @Override
- public void trackSnippetMenuOpened(SnippetArticle article) {}
-
- @Override
- public void trackSnippetCategoryActionImpression(int category, int position) {}
-
- @Override
- public void trackSnippetCategoryActionClick(int category, int position) {}
-
- @Override
- public void openSnippet(
- int windowOpenDisposition, SnippetArticle article, int categoryIndex) {}
+ public void openSnippet(int windowOpenDisposition, SnippetArticle article) {}
@Override
public void focusSearchBox(boolean beginVoiceSearch, String pastedText) {}
@@ -163,6 +147,11 @@ public boolean isCurrentPage() {
public ContextMenuManager getContextMenuManager() {
return mContextMenuManager;
}
+
+ @Override
+ public SuggestionsMetricsReporter getSuggestionsMetricsReporter() {
+ return mSnippetsBridge;
+ }
}
@Override
@@ -198,6 +187,10 @@ protected void onDestroy() {
for (DestructionObserver observer : mDestructionObservers) {
observer.onDestroy();
}
+
+ mSnippetsBridge.destroy();
+ mSnippetsBridge = null;
+
super.onDestroy();
}
}

Powered by Google App Engine
This is Rietveld 408576698