Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore (Closed)
Patch Set: rebase, address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index b683aa3f09562f9d9308c17ff0e4432f340169e1..c6cc0ea9a4bd853b22f09dabb13c15e629767fd6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -63,6 +63,7 @@
import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrlServiceObserver;
import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
+import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;
import org.chromium.chrome.browser.sync.SyncSessionsMetrics;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
@@ -327,56 +328,17 @@ private boolean matchURLs(String url1, String url2, boolean matchByHost) {
return matchByHost ? UrlUtilities.sameHost(url1, url2) : url1.equals(url2);
}
- @Override
- public void trackSnippetsPageImpression(int[] categories, int[] suggestionsPerCategory) {
- mSnippetsBridge.onPageShown(categories, suggestionsPerCategory);
- }
-
- @Override
- public void trackSnippetImpression(SnippetArticle article) {
- mSnippetsBridge.onSuggestionShown(article);
- }
-
- @Override
- public void trackSnippetMenuOpened(SnippetArticle article) {
- mSnippetsBridge.onSuggestionMenuOpened(article);
- }
-
- @Override
- public void trackSnippetCategoryActionImpression(int category, int position) {
- mSnippetsBridge.onMoreButtonShown(category, position);
- }
-
- @Override
- public void trackSnippetCategoryActionClick(int category, int position) {
- mSnippetsBridge.onMoreButtonClicked(category, position);
- switch (category) {
- case KnownCategories.BOOKMARKS:
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARKS_MANAGER);
- break;
- // MORE button in both categories leads to the recent tabs manager
- case KnownCategories.FOREIGN_TABS:
- case KnownCategories.RECENT_TABS:
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_RECENT_TABS_MANAGER);
- break;
- case KnownCategories.DOWNLOADS:
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_DOWNLOADS_MANAGER);
- break;
- default:
- // No action associated
- break;
- }
+ public SuggestionsMetricsReporter getSuggestionsMetricsReporter() {
+ return mSnippetsBridge;
}
- public void trackSnippetOpened(
- int windowOpenDisposition, SnippetArticle article, int categoryIndex) {
- mSnippetsBridge.onSuggestionOpened(article, categoryIndex, windowOpenDisposition);
+ public void trackSnippetOpened(int windowOpenDisposition, SnippetArticle article) {
+ mSnippetsBridge.onSuggestionOpened(article, windowOpenDisposition);
}
@Override
- public void openSnippet(
- int windowOpenDisposition, SnippetArticle article, int categoryIndex) {
- trackSnippetOpened(windowOpenDisposition, article, categoryIndex);
+ public void openSnippet(int windowOpenDisposition, SnippetArticle article) {
+ trackSnippetOpened(windowOpenDisposition, article);
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);
if (article.mIsAssetDownload) {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698