chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java - Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore (Closed)

Patch Set: Fix action item reported position Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

index 913e9c296123fbe5adb79fa84e4437b147e65a65..92cdf2b204007c34489c183ac59f993a6368d993 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

@@ -110,7 +110,7 @@ public void onDisplayStyleChanged(@UiConfig.DisplayStyle int newDisplayStyle) {

@Override

public void onImpression() {

if (mArticle != null && mArticle.trackImpression()) {

- mNewTabPageManager.trackSnippetImpression(mArticle);

+ mNewTabPageManager.getSuggestionsMetricsReporter().onSuggestionShown(mArticle);

mRecyclerView.onSnippetImpression();

}

@@ -151,7 +151,7 @@ public boolean isItemSupported(@ContextMenuItemId int menuItemId) {

@Override

public void onContextMenuCreated() {

- mNewTabPageManager.trackSnippetMenuOpened(mArticle);

+ mNewTabPageManager.getSuggestionsMetricsReporter().onSuggestionMenuOpened(mArticle);

}

@Override