📰 Tweak the suggestion ranks for UMA to handle fetchMore

chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp.snippets;
 
 import android.annotation.SuppressLint;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.drawable.BitmapDrawable;
@@ skipping 52 matching lines @@
     private final TextView mHeadlineTextView;
     private final TextView mPublisherTextView;
     private final TextView mArticleSnippetTextView;
     private final ImageView mThumbnailView;
     private final ImageView mOfflineBadge;
     private final View mPublisherBar;
 
     private FetchImageCallback mImageCallback;
     private SnippetArticle mArticle;
     private SuggestionsCategoryInfo mCategoryInfo;
-    private int mCategoryIndex;
     private int mPublisherFaviconSizePx;
 
     private final boolean mUseFaviconService;
     private final UiConfig mUiConfig;
 
     /**
      * Constructs a {@link SnippetArticleViewHolder} item used to display snippets.
      *
      * @param parent The NewTabPageRecyclerView that is going to contain the newly created view.
      * @param manager The NewTabPageManager object used to open an article.
@@ skipping 20 matching lines @@
                 updateLayout();
             }
         });
 
         mUseFaviconService = CardsVariationParameters.isFaviconServiceEnabled();
     }
 
     @Override
     public void onImpression() {
         if (mArticle != null && mArticle.trackImpression()) {
-            mNewTabPageManager.trackSnippetImpression(mArticle);
+            mNewTabPageManager.getSuggestionsMetricsReporter().onSuggestionShown(mArticle);
             mRecyclerView.onSnippetImpression();
         }
     }
 
     @Override
     public void onCardTapped() {
-        mNewTabPageManager.openSnippet(WindowOpenDisposition.CURRENT_TAB, mArticle, mCategoryIndex);
+        mNewTabPageManager.openSnippet(WindowOpenDisposition.CURRENT_TAB, mArticle);
     }
 
     @Override
     public void openItem(int windowDisposition) {
-        mNewTabPageManager.openSnippet(windowDisposition, mArticle, mCategoryIndex);
+        mNewTabPageManager.openSnippet(windowDisposition, mArticle);
     }
 
     @Override
     public void removeItem() {
         getRecyclerView().dismissItemWithAnimation(this);
     }
 
     @Override
     public String getUrl() {
         return mArticle.mUrl;
     }
 
     @Override
     public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
         if (mArticle.isDownload()) {
             if (menuItemId == ContextMenuManager.ID_OPEN_IN_INCOGNITO_TAB) return false;
             if (menuItemId == ContextMenuManager.ID_SAVE_FOR_OFFLINE) return false;
             return true;
         }
         if (mArticle.isRecentTab()) {
             if (menuItemId == ContextMenuManager.ID_REMOVE) return true;
             return false;
         }
         return true;
     }
 
     @Override
     public void onContextMenuCreated() {
-        mNewTabPageManager.trackSnippetMenuOpened(mArticle);
+        mNewTabPageManager.getSuggestionsMetricsReporter().onSuggestionMenuOpened(mArticle);
     }
 
     @Override
     protected Delegate getContextMenuDelegate() {
         return this;
     }
 
     /**
      * Updates the layout taking into account screen dimensions and the type of snippet displayed.
      */
@@ skipping 51 matching lines @@
                     SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
         } finally {
             StrictMode.setThreadPolicy(oldPolicy);
         }
         // We format the publisher here so that having a publisher name in an RTL language
         // doesn't mess up the formatting on an LTR device and vice versa.
         return String.format(PUBLISHER_FORMAT_STRING,
                 BidiFormatter.getInstance().unicodeWrap(article.mPublisher), relativeTimeSpan);
     }
 
-    public void onBindViewHolder(SnippetArticle article, SuggestionsCategoryInfo categoryInfo,
-            List<Object> payloads, int categoryIndex) {
+    public void onBindViewHolder(
+            SnippetArticle article, SuggestionsCategoryInfo categoryInfo, List<Object> payloads) {
         if (!payloads.isEmpty() && article.equals(mArticle)) {
             performPartialBind(payloads);
             return;
         }
 
         super.onBindViewHolder();
 
         mArticle = article;
         mCategoryInfo = categoryInfo;
-        mCategoryIndex = categoryIndex;
         updateLayout();
 
         mHeadlineTextView.setText(mArticle.mTitle);
         mPublisherTextView.setText(getAttributionString(mArticle));
 
         // The favicon of the publisher should match the TextView height.
         int widthSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);
         int heightSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);
         mPublisherTextView.measure(widthSpec, heightSpec);
         mPublisherFaviconSizePx = mPublisherTextView.getMeasuredHeight();
@@ skipping 164 matching lines @@
         ApiCompatibilityUtils.setCompoundDrawablesRelative(
                 mPublisherTextView, drawable, null, null, null);
         mPublisherTextView.setVisibility(View.VISIBLE);
     }
 
     @Override
     public boolean isDismissable() {
         return !isPeeking();
     }
 }