Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: base/allocator/partition_allocator/partition_alloc_unittest.cc

Issue 2618853002: Don't run memory-intensive tests on low-memory devices. (Closed)
Patch Set: Make GenericAllocGetSize a no-op, too. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/partition_allocator/partition_alloc_unittest.cc
diff --git a/base/allocator/partition_allocator/partition_alloc_unittest.cc b/base/allocator/partition_allocator/partition_alloc_unittest.cc
index 30a89226f2b34393d5ac8e5a72e5f2b887de880c..311e82cf2240cac659d0584f5a1618bdf914940a 100644
--- a/base/allocator/partition_allocator/partition_alloc_unittest.cc
+++ b/base/allocator/partition_allocator/partition_alloc_unittest.cc
@@ -611,6 +611,12 @@ TEST(PartitionAllocTest, GenericAlloc) {
// Test the generic allocation functions can handle some specific sizes of
// interest.
TEST(PartitionAllocTest, GenericAllocSizes) {
+ // TODO: Where necessary and possible, disable the platform's OOM-killing
danakj 2017/01/05 23:00:44 TODO, unlike the old FIXME, always comes with a na
palmer 2017/01/06 00:30:53 Done.
+ // behavior. OOM-killing makes this test flaky on low-memory devices.
+ // crbug.com/678782
+ if (!IsLargeMemoryDevice())
+ return;
+
TestSetup();
void* ptr = partitionAllocGeneric(genericAllocator.root(), 0, typeName);
@@ -708,6 +714,10 @@ TEST(PartitionAllocTest, GenericAllocSizes) {
// Test that we can fetch the real allocated size after an allocation.
TEST(PartitionAllocTest, GenericAllocGetSize) {
+ // TODO: Where necessary and possible, disable the platform's OOM-killing
+ // behavior. OOM-killing makes this test flaky on low-memory devices.
danakj 2017/01/05 23:00:44 If it's flaky shouldn't it be disabled, or is the
palmer 2017/01/06 00:30:53 Oops, forgot to put the actual code in. Sigh.
+ // crbug.com/678782
+
TestSetup();
void* ptr;
@@ -1266,6 +1276,12 @@ TEST(PartitionAllocTest, LostFreePagesBug) {
#if !defined(ARCH_CPU_64_BITS) || defined(OS_POSIX)
static void DoReturnNullTest(size_t allocSize) {
+ // TODO: Where necessary and possible, disable the platform's OOM-killing
+ // behavior. OOM-killing makes this test flaky on low-memory devices.
+ // crbug.com/678782
+ if (!IsLargeMemoryDevice())
+ return;
+
TestSetup();
EXPECT_TRUE(SetAddressSpaceLimit());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698