Use previous target path when resuming a download after crash

content/browser/download/download_item_impl_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_item_impl_delegate.h"
 
 #include "base/logging.h"
 #include "content/browser/download/download_item_impl.h"
 
 namespace content {
@@ skipping 11 matching lines @@
   ++count_;
 }
 
 void DownloadItemImplDelegate::Detach() {
   DCHECK_LT(0, count_);
   --count_;
 }
 
 void DownloadItemImplDelegate::DetermineDownloadTarget(
     DownloadItemImpl* download, const DownloadTargetCallback& callback) {
-  // TODO(rdsmith/asanka): Do something useful if forced file path is null.
-  base::FilePath target_path(download->GetForcedFilePath());
+  // TODO(qinmin): Do something useful if both forced file path and
+  // target file path are empty. This code path is unreachable. It's
+  // here because we cannot rely on embedder to replace the implementation.
+  base::FilePath target_path = download->GetForcedFilePath().empty() ?

[asanka, 2017/01/10 22:24:03]

The changes in this file are not necessary. The last-target-path logic is
//chrome specific.

[qinmin, 2017/01/10 23:04:42]

ok, reverted the change

+      download->GetTargetFilePath() : download->GetForcedFilePath();
   callback.Run(target_path,
                DownloadItem::TARGET_DISPOSITION_OVERWRITE,
                DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
                target_path);
 }
 
 bool DownloadItemImplDelegate::ShouldCompleteDownload(
     DownloadItemImpl* download,
     const base::Closure& complete_callback) {
   return true;
@@ skipping 31 matching lines @@
 
 void DownloadItemImplDelegate::ShowDownloadInShell(DownloadItemImpl* download) {
 }
 
 void DownloadItemImplDelegate::DownloadRemoved(DownloadItemImpl* download) {}
 
 void DownloadItemImplDelegate::AssertStateConsistent(
     DownloadItemImpl* download) const {}
 
 }  // namespace content