Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/battor_agent/battor_agent.cc

Issue 2618693003: Fix logic for retrying BattOr initialization after a timeout (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/battor_agent/battor_agent.cc
diff --git a/tools/battor_agent/battor_agent.cc b/tools/battor_agent/battor_agent.cc
index 27753491bab97398fcc4c574094d5be48c340ae1..ce9e1f6abb77c384e13438a2b7aa3dc86badb234 100644
--- a/tools/battor_agent/battor_agent.cc
+++ b/tools/battor_agent/battor_agent.cc
@@ -545,7 +545,6 @@ void BattOrAgent::OnActionTimeout() {
} else {
CompleteCommand(BATTOR_ERROR_TOO_MANY_INIT_RETRIES);
}
-
return;
// TODO(crbug.com/672631): There's currently a BattOr firmware bug that's
@@ -563,12 +562,12 @@ void BattOrAgent::OnActionTimeout() {
} else {
CompleteCommand(BATTOR_ERROR_TOO_MANY_START_TRACING_RETRIES);
}
+ return;
default:
CompleteCommand(BATTOR_ERROR_TIMEOUT);
+ timeout_callback_.Cancel();
}
-
- timeout_callback_.Cancel();
}
void BattOrAgent::SendControlMessage(BattOrControlMessageType type,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698