Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2618633006: Create a wrapper class to handle CompilerOptions in a uniform way. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a wrapper class to handle CompilerOptions in a uniform way. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/ca271d003e143119ecd3fd1d5e35dd932418a96d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -18 lines) Patch
M pkg/front_end/lib/dependency_grapher.dart View 2 chunks +4 lines, -18 lines 0 comments Download
A pkg/front_end/lib/src/base/processed_options.dart View 1 chunk +84 lines, -0 lines 0 comments Download
A pkg/front_end/test/src/base/processed_options_test.dart View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-06 18:01:30 UTC) #2
danrubel
LGTM
3 years, 11 months ago (2017-01-06 18:16:49 UTC) #3
Paul Berry
3 years, 11 months ago (2017-01-06 18:40:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca271d003e143119ecd3fd1d5e35dd932418a96d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698