third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp - Issue 2618633004: Add support for Animated PNG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

Issue 2618633004: Add support for Animated PNG (Closed)

Patch Set: Reject bad data. Cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h ('k') | third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.h » ('j') | third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

index 357917f67d3cff36f6b0a9e23a76c2d9e9ad86c2..45a7170f13a8d3ee76029234a7caa2aa441a3f40 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

@@ -268,8 +268,9 @@ void GIFImageDecoder::parse(GIFParseQuery query) {

setFailed();

}

-void GIFImageDecoder::onInitFrameBuffer(size_t frameIndex) {

+bool GIFImageDecoder::onInitFrameBuffer(size_t frameIndex) {

m_currentBufferSawAlpha = false;

+ return true;

}

bool GIFImageDecoder::canReusePreviousFrameBuffer(size_t frameIndex) const {