third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp - Issue 2618633004: Add support for Animated PNG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

Issue 2618633004: Add support for Animated PNG (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

index 27757d089441b3ae6fd6878105736ce47dd26946..2b376f9949c742cc9a106d15d839333396789e60 100644

--- a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

@@ -417,8 +417,11 @@ void WEBPImageDecoder::decode(size_t index) {

DCHECK(m_demux);

for (auto i = framesToDecode.rbegin(); i != framesToDecode.rend(); ++i) {

- if ((m_formatFlags & ANIMATION_FLAG) && !initFrameBuffer(*i))

+ if ((m_formatFlags & ANIMATION_FLAG) && !initFrameBuffer(*i)) {

+ setFailed();

return;

+ }

WebPIterator webpFrame;

if (!WebPDemuxGetFrame(m_demux, *i + 1, &webpFrame)) {

setFailed();