Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 26186003: Revert: Android perf tests: kill adbd on the device after running a test. (Closed)

Created:
7 years, 2 months ago by bulach
Modified:
7 years, 2 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Revert: Android perf tests: kill adbd on the device after running a test. There's some data indicating that adbd on the device sometimes spontaneously restores its connection. After running a test, let's kill adbd and forwarder and wait for bit. Reverts crrev.com/227038: this is not helping. BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M build/android/pylib/android_commands.py View 1 chunk +0 lines, -8 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
bulach
still something fishy going on with the forwarder... :( reverting again..
7 years, 2 months ago (2013-10-06 19:11:23 UTC) #1
navabi
lgtm
7 years, 2 months ago (2013-10-06 20:57:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 05:57:10 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-07 06:04:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 06:38:09 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 07:04:58 UTC) #6
rmcilroy
lgtm
7 years, 2 months ago (2013-10-07 07:26:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 07:26:38 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 07:49:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 09:29:27 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 10:04:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 10:45:35 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 11:10:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 11:12:02 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 11:51:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 15:11:15 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 15:40:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/26186003/1
7 years, 2 months ago (2013-10-07 15:46:28 UTC) #18
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 15:47:26 UTC) #19
Message was sent while issue was closed.
Change committed as 227278

Powered by Google App Engine
This is Rietveld 408576698