Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2618583003: [InputEvent] Add 'beforeinput' logic in |will*()| and guarded by a flag (3/11) (Closed)
Patch Set: Change target to |startingRootEditableElement()| Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/EditingUtilities.h
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.h b/third_party/WebKit/Source/core/editing/EditingUtilities.h
index cc83fb609ec6479173149750eb91518d0a86910e..82d76463c15fc038591d6bbe42c7fa14e138954e 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.h
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.h
@@ -58,6 +58,7 @@ enum class DeleteDirection {
Backward,
};
+enum class EditCommandSource;
class CompositeEditCommand;
class Document;
class Element;
@@ -412,10 +413,12 @@ String stringWithRebalancedWhitespace(const String&,
const String& nonBreakingSpaceString();
// -------------------------------------------------------------------------
-// Events
+// InputEvent
// -------------------------------------------------------------------------
-// Functions dispatch InputEvent
+// TODO(chongz): Remove the following 4 |dispatch*()|after we have moved all
+// 'beforeinput' logic into |CompositeEditCommand.cpp|.
+// https://crbug.com/670035
DispatchEventResult dispatchBeforeInputInsertText(EventTarget*,
const String& data);
DispatchEventResult dispatchBeforeInputFromComposition(
@@ -441,6 +444,19 @@ InputEvent::InputType deletionInputTypeFromTextGranularity(DeleteDirection,
InputEvent::EventIsComposing isComposingFromCommand(
const CompositeEditCommand*);
+// TODO(chongz): Move |dispatchBeforeInputEvent()| to 'CompositeEditCommand.cpp'
+// after we've resolved the ordering issue WRT 'compositionupdate'.
+// https://crbug.com/675820
+bool dispatchBeforeInputEvent(EditCommandSource,
+ LocalFrame*,
+ Node* target,
+ InputEvent::InputType,
+ const String& data,
+ DataTransfer*,
+ InputEvent::EventCancelable,
+ InputEvent::EventIsComposing,
+ const RangeVector*);
+
} // namespace blink
#endif
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698