[compiler] Collect eager inner functions for compilation during renumbering.

src/ast/ast-numbering.h

Index: src/ast/ast-numbering.h
diff --git a/src/ast/ast-numbering.h b/src/ast/ast-numbering.h
index 73278950cd220919abcb200fd1fb689e0fc3991f..31bd0872de641e171f6f599cdd405339e2b91c36 100644
--- a/src/ast/ast-numbering.h
+++ b/src/ast/ast-numbering.h
@@ -12,11 +12,15 @@ namespace internal {
 class FunctionLiteral;
 class Isolate;
 class Zone;
+template <typename T>
+class ZoneVector;
 
 namespace AstNumbering {
 // Assign type feedback IDs, bailout IDs, and generator yield IDs to an AST node
-// tree; perform catch prediction for TryStatements.
-bool Renumber(Isolate* isolate, Zone* zone, FunctionLiteral* function);
+// tree; perform catch prediction for TryStatements. Adds any eager inner
+// literal functions found into |eager_inner_functions|.
+bool Renumber(Isolate* isolate, Zone* zone, FunctionLiteral* function,
+              ZoneVector<FunctionLiteral*>* eager_inner_functions);

[marja, 2017/01/05 19:25:22]

I was thinking about the ZoneVector usage here... the number of eager inner
functions can be big, and ZoneVectors are wasteful (every time it is expanded,
we cannot discard the old backing store).

Do you have some numbers based on which we could decide whether this choice of
data structure is fine or not? Can we initialize the ZoneVector intelligently so
that it wouldn't need to expand so much?

ThreadedList (sic) would be an alternative, but then you'd need to create a
separate class for holding the FunctionLiteral* and the next pointer. (Maybe
adding such a class in a templatized way would be a good idea.)

[rmcilroy, 2017/01/06 17:08:14]

Yes good point, I'm not sure we have a good default which we could intelligently
initialize ZoneVector with. I'll have a look at ThreadedList instead.

[rmcilroy, 2017/01/09 16:50:10]

Done.

 }
 
 // Some details on yield IDs