Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc

Issue 2618553004: [compiler] Collect eager inner functions for compilation during renumbering. (Closed)
Patch Set: Remove unused variable Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler.cc ('K') | « src/parsing/parse-info.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
diff --git a/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc b/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
index e1101dfe31f6c49bec3b44c50fd401c34cdebf23..ec06cd727ddf01040aa2887664deca4b5e98f279 100644
--- a/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
+++ b/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
@@ -322,36 +322,5 @@ TEST_F(IgnitionCompilerDispatcherJobTest, CompileOnBackgroundThread) {
ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
}
-TEST_F(CompilerDispatcherJobTest, LazyInnerFunctions) {
- const char script[] =
- "function g() {\n"
- " f = function() {\n"
- " e = (function() { return 42; });\n"
- " return e;\n"
- " };\n"
- " return f;\n"
- "}\n"
- "g();";
- Handle<JSFunction> f = Handle<JSFunction>::cast(RunJS(isolate(), script));
-
- std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
- i_isolate(), tracer(), handle(f->shared()), FLAG_stack_size));
-
- job->PrepareToParseOnMainThread();
- job->Parse();
- ASSERT_TRUE(job->FinalizeParsingOnMainThread());
- ASSERT_TRUE(job->PrepareToCompileOnMainThread());
- job->Compile();
- ASSERT_TRUE(job->FinalizeCompilingOnMainThread());
- ASSERT_TRUE(job->status() == CompileJobStatus::kDone);
-
- Handle<JSFunction> e = Handle<JSFunction>::cast(RunJS(isolate(), "f();"));
-
- ASSERT_FALSE(e->shared()->HasBaselineCode());
marja 2017/01/05 19:25:22 Hmm, I don't understand why this test is removed..
rmcilroy 2017/01/06 17:08:14 This was part of the revert of the LazyCompileMode
-
- job->ResetOnMainThread();
- ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
-}
-
} // namespace internal
} // namespace v8
« src/compiler.cc ('K') | « src/parsing/parse-info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698