[compiler] Collect eager inner functions for compilation during renumbering.

src/zone/zone-containers.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_SRC_ZONE_ZONE_CONTAINERS_H_
 #define V8_SRC_ZONE_ZONE_CONTAINERS_H_
 
 #include <deque>
 #include <list>
 #include <map>
 #include <queue>
 #include <set>
 #include <stack>
 #include <vector>
 
+#include "src/utils.h"

[marja, 2017/01/10 10:10:43]

Why?

[rmcilroy, 2017/01/11 10:20:11]

You are right , this wasn't needed (removed anyway since I moved the helper into
utils.h instead).

 #include "src/zone/zone-allocator.h"
 
 namespace v8 {
 namespace internal {
 
 // A wrapper subclass for std::vector to make it easy to construct one
 // that uses a zone allocator.
 template <typename T>
 class ZoneVector : public std::vector<T, zone_allocator<T>> {
  public:
@@ skipping 106 matching lines @@
   // Constructs an empty multimap.
   explicit ZoneMultimap(Zone* zone)
       : std::multimap<K, V, Compare, zone_allocator<std::pair<const K, V>>>(
             Compare(), zone_allocator<std::pair<const K, V>>(zone)) {}
 };
 
 // Typedefs to shorten commonly used vectors.
 typedef ZoneVector<bool> BoolVector;
 typedef ZoneVector<int> IntVector;
 
+// Can be used to create a threaded list of |T|.
+template <typename T>
+class ThreadedListZoneEntry final : public ZoneObject {

[Michael Starzinger, 2017/01/10 12:26:09]

This file is specifically meant to contain stdlib containers living on the zone
(and specifically don't subclass ZoneObject). Could we move this helper class
into the utils.h file instead, close to our hand-woven ThreadedList class?

[rmcilroy, 2017/01/11 10:20:11]

I had it there originally but it means src/utils.h needs to to include
src/zone/zone.h (for ZoneObject), however that created a circular dependency
since zone.h already includes src/utils.h (indirectly through src/list.h). 

It turns out list.h only needed vector.h, so I broke the cycle  and moved this
back into utils.h, however it needed a bit of include munging across the
codebase.

+ public:
+  explicit ThreadedListZoneEntry(T value) : value_(value), next_(nullptr) {}
+
+  T value() { return value_; }
+  ThreadedListZoneEntry<T>** next() { return &next_; }
+
+ private:
+  T value_;
+  ThreadedListZoneEntry<T>* next_;
+};

[jochen (gone - plz use gerrit), 2017/01/10 09:57:39]

disallow copy/assign?

[rmcilroy, 2017/01/11 10:20:11]

Done.

+
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_SRC_ZONE_ZONE_CONTAINERS_H_