ParamVarDecl should never be renamed to kConstantStyle.

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index 83c6eb22e6270c918918efe1d359a41be0b4d2ba..90bcdb4981d40d0fa335be46f6f42445fade3e8a 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -330,6 +330,11 @@ bool IsProbablyConst(const clang::VarDecl& decl,
   if (type.isVolatileQualified())
     return false;
 
+  // Parameters should not be renamed to |kFooBar| style (even if they are
+  // const and have an initializer (aka default value)).
+  if (clang::ParmVarDecl::classof(&decl))

[dcheng, 2017/01/04 23:21:31]

Nit: more standard to write:

clang::isa<clang::ParmVarDecl>(&decl)

IIRC, classof is an internal implementation detail that supports the isa/dyncast
machinery.

[Łukasz Anforowicz, 2017/01/04 23:30:43]

Thanks.  I was trying to recall/find how to spell this and had trouble wit this.
 Done.

+    return false;
+
   // http://google.github.io/styleguide/cppguide.html#Constant_Names
   // Static variables that are const-qualified should use kConstantStyle naming.
   if (decl.getStorageDuration() == clang::SD_Static)