chrome/chrome_browser.gypi - Issue 261853012: Componentize GCM Part 1: create GCM component and move some files over

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 261853012: Componentize GCM Part 1: create GCM component and move some files over (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix trybot Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index b935c1acf45e7eb3855a4449e8d10d9a56f4fe57..c86d216b1e642d23c893eea2e7cf830fe2200d21 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -36,6 +36,7 @@

'../components/components.gyp:domain_reliability',

'../components/components.gyp:favicon_base',

'../components/components.gyp:favicon_core',

+ '../components/components.gyp:gcm',

Nicolas Zea 2014/05/07 20:07:00 shouldn't we be calling this gcm_driver?

jianli 2014/05/07 20:12:15 I prefer to simplify it as gcm in order to be cons

'../components/components.gyp:infobars_core',

'../components/components.gyp:metrics',

'../components/components.gyp:navigation_metrics',

@@ -1989,11 +1990,6 @@

'browser/search_engines/template_url_service_observer.h',

'browser/search_engines/util.cc',

'browser/search_engines/util.h',

- 'browser/services/gcm/default_gcm_app_handler.cc',

- 'browser/services/gcm/default_gcm_app_handler.h',

- 'browser/services/gcm/gcm_app_handler.h',

- 'browser/services/gcm/gcm_client_factory.cc',

- 'browser/services/gcm/gcm_client_factory.h',

'browser/services/gcm/gcm_profile_service.cc',

'browser/services/gcm/gcm_profile_service.h',

'browser/services/gcm/gcm_profile_service_factory.cc',

« no previous file with comments | « chrome/browser/services/gcm/gcm_service_unittest.cc ('k') | components/OWNERS » ('j') | google_apis/gcm/gcm_client_impl.h » ('J')