Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: google_apis/gcm/engine/gcm_store_impl.cc

Issue 261853012: Componentize GCM Part 1: create GCM component and move some files over (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/gcm_store_impl.h ('k') | google_apis/gcm/engine/gcm_store_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/gcm_store_impl.cc
diff --git a/google_apis/gcm/engine/gcm_store_impl.cc b/google_apis/gcm/engine/gcm_store_impl.cc
index 5393fd1a9fd2a0d20d5bec3437251c58b7bda86d..8c6f730f43b274624db810e3a05ef7078cb312a0 100644
--- a/google_apis/gcm/engine/gcm_store_impl.cc
+++ b/google_apis/gcm/engine/gcm_store_impl.cc
@@ -18,7 +18,7 @@
#include "base/strings/string_piece.h"
#include "base/time/time.h"
#include "base/tracked_objects.h"
-#include "components/os_crypt/os_crypt.h"
+#include "google_apis/gcm/base/encryptor.h"
#include "google_apis/gcm/base/mcs_message.h"
#include "google_apis/gcm/base/mcs_util.h"
#include "google_apis/gcm/protocol/mcs.pb.h"
@@ -107,7 +107,8 @@ class GCMStoreImpl::Backend
: public base::RefCountedThreadSafe<GCMStoreImpl::Backend> {
public:
Backend(const base::FilePath& path,
- scoped_refptr<base::SequencedTaskRunner> foreground_runner);
+ scoped_refptr<base::SequencedTaskRunner> foreground_runner,
+ scoped_ptr<Encryptor> encryptor);
// Blocking implementations of GCMStoreImpl methods.
void Load(const LoadCallback& callback);
@@ -158,14 +159,19 @@ class GCMStoreImpl::Backend
const base::FilePath path_;
scoped_refptr<base::SequencedTaskRunner> foreground_task_runner_;
+ scoped_ptr<Encryptor> encryptor_;
scoped_ptr<leveldb::DB> db_;
};
GCMStoreImpl::Backend::Backend(
const base::FilePath& path,
- scoped_refptr<base::SequencedTaskRunner> foreground_task_runner)
- : path_(path), foreground_task_runner_(foreground_task_runner) {}
+ scoped_refptr<base::SequencedTaskRunner> foreground_task_runner,
+ scoped_ptr<Encryptor> encryptor)
+ : path_(path),
+ foreground_task_runner_(foreground_task_runner),
+ encryptor_(encryptor.Pass()) {
+}
GCMStoreImpl::Backend::~Backend() {}
@@ -278,8 +284,8 @@ void GCMStoreImpl::Backend::SetDeviceCredentials(
write_options.sync = true;
std::string encrypted_token;
- OSCrypt::EncryptString(base::Uint64ToString(device_security_token),
- &encrypted_token);
+ encryptor_->EncryptString(base::Uint64ToString(device_security_token),
+ &encrypted_token);
std::string android_id_str = base::Uint64ToString(device_android_id);
leveldb::Status s =
db_->Put(write_options,
@@ -551,7 +557,7 @@ bool GCMStoreImpl::Backend::LoadDeviceCredentials(uint64* android_id,
}
if (s.ok()) {
std::string decrypted_token;
- OSCrypt::DecryptString(result, &decrypted_token);
+ encryptor_->DecryptString(result, &decrypted_token);
if (!base::StringToUint64(decrypted_token, security_token)) {
LOG(ERROR) << "Failed to restore security token.";
return false;
@@ -699,8 +705,11 @@ bool GCMStoreImpl::Backend::LoadGServicesSettings(
GCMStoreImpl::GCMStoreImpl(
const base::FilePath& path,
- scoped_refptr<base::SequencedTaskRunner> blocking_task_runner)
- : backend_(new Backend(path, base::MessageLoopProxy::current())),
+ scoped_refptr<base::SequencedTaskRunner> blocking_task_runner,
+ scoped_ptr<Encryptor> encryptor)
+ : backend_(new Backend(path,
+ base::MessageLoopProxy::current(),
+ encryptor.Pass())),
blocking_task_runner_(blocking_task_runner),
weak_ptr_factory_(this) {
}
« no previous file with comments | « google_apis/gcm/engine/gcm_store_impl.h ('k') | google_apis/gcm/engine/gcm_store_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698