Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: components/components.gyp

Issue 261853012: Componentize GCM Part 1: create GCM component and move some files over (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update gyp Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/OWNERS ('k') | components/gcm.gypi » ('j') | components/gcm.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/components.gyp
diff --git a/components/components.gyp b/components/components.gyp
index e7b7491dfabda3b92f5c6138d555c309bf638d53..749ce979db97a6e3055b31ac555b1c388a89515a 100644
--- a/components/components.gyp
+++ b/components/components.gyp
@@ -66,6 +66,13 @@
'usb_service.gypi',
]
}],
+ ['OS != "android"', {
+ # For now, gcm component should not be built for Android. We will include
+ # it once we remove the depdency on google_apis/gcm for Android.
blundell 2014/05/09 08:23:35 Should there be a TODO and bug reference here?
Nicolas Zea 2014/05/09 17:55:14 nit: depdency -> dependency
jianli 2014/05/09 21:29:37 Done.
jianli 2014/05/09 21:29:37 This is part of the GCM componentization effort. S
+ 'includes': [
+ 'gcm.gypi',
+ ]
+ }],
['android_webview_build == 0', {
# Android WebView fails to build if a dependency on sync.gyp:sync is
# introduced.
« no previous file with comments | « components/OWNERS ('k') | components/gcm.gypi » ('j') | components/gcm.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698