Issue 261853009: Fixed jump in non-SSE4.1 implementation of LMathFloor instruction on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 261853009: Fixed jump in non-SSE4.1 implementation of LMathFloor instruction on x64. (Closed)

Created:
6 years, 7 months ago by Igor Sheludko

Modified:
6 years, 7 months ago

Reviewers:
Sven Panne, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed jump in non-SSE4.1 implementation of LMathFloor instruction on x64. BUG=chromium:370384 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21171

Patch Set 2 : Addressing review comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-370384.js	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

DBC https://codereview.chromium.org/261853009/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/261853009/diff/1/src/x64/lithium-codegen-x64.cc#newcode3642 src/x64/lithium-codegen-x64.cc:3642: __ jmp(&done, Label::kFar); Normally we just leave out ...

6 years, 7 months ago (2014-05-06 13:04:30 UTC) #3

Igor Sheludko

6 years, 7 months ago (2014-05-06 14:20:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21171 (presubmit successful).

Expand Messages | Collapse Messages

Issue 261853009: Fixed jump in non-SSE4.1 implementation of LMathFloor instruction on x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing review comments #

Messages