Issue 2618523005: Make HTTP headers use a growing buffer, not a fixed-size 8K one.

Issue 2618523005: Make HTTP headers use a growing buffer, not a fixed-size 8K one. (Closed)

Created:
3 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
3 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make HTTP headers use a growing buffer, not a fixed-size 8K one. Issue #28251 BUG= http://dartbug.com/28251 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/51197954224cc98439670f08e0b5553c643b4e96

Patch Set 2 : Also fix other _writeHeaders implementation. #

Patch Set 3 : Remove error message and tests expecting it. #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -146 lines)			Patch
M	sdk/lib/io/bytes_builder.dart	View	1 2	5 chunks	+45 lines, -20 lines	0 comments	Download
M	sdk/lib/io/http_headers.dart	View	1	1 chunk	+14 lines, -24 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1 2	7 chunks	+41 lines, -70 lines	0 comments	Download
M	tests/standalone/io/http_client_request_test.dart	View	1 2	1 chunk	+0 lines, -17 lines	0 comments	Download
M	tests/standalone/io/http_server_response_test.dart	View	1 2	2 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

See anything problematic about this approach?

3 years, 11 months ago (2017-01-05 13:28:40 UTC) #2

Søren Gjesse

Looks fine to me, but you should also fix the error message here: https://github.com/dart-lang/sdk/blob/dff9e61d4dcf3df8fced73801fbb9f32669b8c39/sdk/lib/io/http_impl.dart#L937 https://codereview.chromium.org/2618523005/diff/1/sdk/lib/io/http_impl.dart ...

3 years, 11 months ago (2017-01-05 14:22:12 UTC) #3

Lasse Reichstein Nielsen

PTAL https://codereview.chromium.org/2618523005/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (left): https://codereview.chromium.org/2618523005/diff/1/sdk/lib/io/http_impl.dart#oldcode633 sdk/lib/io/http_impl.dart:633: offset = headers._write(buffer, offset); There is another implementation ...

3 years, 11 months ago (2017-01-13 06:22:59 UTC) #4

Lasse Reichstein Nielsen

3 years, 11 months ago (2017-01-13 09:12:25 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
51197954224cc98439670f08e0b5553c643b4e96 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages