Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2376)

Unified Diff: extensions/common/manifest_constants.cc

Issue 2618493002: Chrome app manifest support for action handlers. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index 8d6be3afc21a672ac34961fc5632c51e42d4c070..fb6b759dd734de92f68f5c87356734b2c43b809a 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -10,6 +10,7 @@ namespace extensions {
namespace manifest_keys {
const char kAboutPage[] = "about_page";
+const char kActionHandlers[] = "action_handlers";
const char kAllFrames[] = "all_frames";
const char kAltKey[] = "altKey";
const char kApp[] = "app";
@@ -298,6 +299,10 @@ const char kFileNotFound[] = "File not found: *.";
const char kInvalidAboutPage[] = "Invalid value for 'about_page'.";
const char kInvalidAboutPageExpectRelativePath[] =
"Invalid value for 'about_page'. Value must be a relative path.";
+const char kInvalidActionHandlersActionType[] =
+ "Invalid entry in 'action_handlers': \"*\".";
+const char kInvalidActionHandlersType[] =
+ "Invalid value for 'action_handlers'. Value must be a list of strings.";
const char kInvalidAllFrames[] =
"Invalid value for 'content_scripts[*].all_frames'.";
const char kInvalidAppIconColor[] = "Invalid value for app.icon_color.";

Powered by Google App Engine
This is Rietveld 408576698