components/sync/model/model_type_sync_bridge.cc - Issue 2618483003: [Sync] Introduce ModelError for USS error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model/model_type_sync_bridge.cc

Issue 2618483003: [Sync] Introduce ModelError for USS error handling. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model/model_type_sync_bridge.cc

diff --git a/components/sync/model/model_type_sync_bridge.cc b/components/sync/model/model_type_sync_bridge.cc

index b3b793e693d03fe85a8231766daadc67e5b9ba92..ca6d733b7537c5159fac2dfd4e390e67488caed5 100644

--- a/components/sync/model/model_type_sync_bridge.cc

+++ b/components/sync/model/model_type_sync_bridge.cc

@@ -44,8 +44,7 @@ void ModelTypeSyncBridge::DisableSync() {

// processor that there is no metadata. DisableSync() should never be called

// while the models are loading, aka before the service has finished loading

// the initial metadata.

- change_processor_->OnMetadataLoaded(SyncError(),

- base::MakeUnique<MetadataBatch>());

+ change_processor_->OnMetadataLoaded(base::MakeUnique<MetadataBatch>());

}

ModelTypeChangeProcessor* ModelTypeSyncBridge::change_processor() const {