components/sync/model/model_type_debug_info.cc - Issue 2618483003: [Sync] Introduce ModelError for USS error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model/model_type_debug_info.cc

Issue 2618483003: [Sync] Introduce ModelError for USS error handling. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model/model_type_debug_info.cc

diff --git a/components/sync/model/model_type_debug_info.cc b/components/sync/model/model_type_debug_info.cc

index fa104ce7b72b6a44e836bf311cce27b0624427ca..749842b3151dcac78e254e79a97d26e67786e408 100644

--- a/components/sync/model/model_type_debug_info.cc

+++ b/components/sync/model/model_type_debug_info.cc

@@ -71,7 +71,6 @@ void ModelTypeDebugInfo::MergeDataWithMetadata(

SharedModelTypeProcessor* processor,

const base::Callback<void(const ModelType,

std::unique_ptr<base::ListValue>)>& callback,

- SyncError error,

std::unique_ptr<DataBatch> batch) {

std::unique_ptr<base::ListValue> all_nodes =

base::MakeUnique<base::ListValue>();