components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc - Issue 2618483003: [Sync] Introduce ModelError for USS error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc

Issue 2618483003: [Sync] Introduce ModelError for USS error handling. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc ('k') | components/reading_list/ios/reading_list_model_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc

diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc b/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc

index 596d67d1812fa2ca7eb1436a2ea8a8706f35ef85..4e7fd4232e3583ed5ffdbf0d409ff5b7be967d21 100644

--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc

+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc

@@ -28,7 +28,6 @@ using sync_pb::AutofillSpecifics;

using sync_pb::EntitySpecifics;

using syncer::EntityDataPtr;

using syncer::EntityData;

-using syncer::SyncError;

namespace autofill {

@@ -42,9 +41,7 @@ void VerifyEqual(const AutofillSpecifics& s1, const AutofillSpecifics& s2) {

}

void VerifyDataBatch(std::map<std::string, AutofillSpecifics> expected,

- SyncError error,

std::unique_ptr<syncer::DataBatch> batch) {

- EXPECT_FALSE(error.IsSet());

while (batch->HasNext()) {

const syncer::KeyAndData& pair = batch->Next();

auto iter = expected.find(pair.first);