Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/sync/test/integration/two_client_uss_sync_test.cc

Issue 2618483003: [Sync] Introduce ModelError for USS error handling. (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/webdata/autocomplete_sync_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc b/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
index 8a6f76c07573cb945ee6fe683cb90f1595bf8e12..f9e97a14e28967a793310800fb1f91197838af22 100644
--- a/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
@@ -16,6 +16,7 @@
#include "components/browser_sync/profile_sync_service.h"
#include "components/sync/model/fake_model_type_sync_bridge.h"
#include "components/sync/model/metadata_change_list.h"
+#include "components/sync/model/model_error.h"
#include "components/sync/model/model_type_change_processor.h"
using browser_sync::ChromeSyncClient;
@@ -63,14 +64,13 @@ class TestModelTypeSyncBridge : public FakeModelTypeSyncBridge {
TestModelTypeSyncBridge()
: FakeModelTypeSyncBridge(base::Bind(&ModelTypeChangeProcessor::Create)) {
- change_processor()->OnMetadataLoaded(syncer::SyncError(),
- db().CreateMetadataBatch());
+ change_processor()->OnMetadataLoaded(db().CreateMetadataBatch());
}
- syncer::SyncError ApplySyncChanges(
+ syncer::ModelError ApplySyncChanges(
std::unique_ptr<syncer::MetadataChangeList> metadata_changes,
syncer::EntityChangeList entity_changes) override {
- syncer::SyncError error = FakeModelTypeSyncBridge::ApplySyncChanges(
+ syncer::ModelError error = FakeModelTypeSyncBridge::ApplySyncChanges(
std::move(metadata_changes), entity_changes);
NotifyObservers();
return error;
@@ -324,7 +324,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientUssSyncTest, Error) {
ASSERT_TRUE(DataChecker(model1, kKey1, kValue1).Wait());
// Set an error in model 1 to trigger in the next GetUpdates.
- model1->ErrorOnNextCall(syncer::SyncError::DATATYPE_ERROR);
+ model1->ErrorOnNextCall();
// Write an item on model 0 to trigger a GetUpdates in model 1.
model0->WriteItem(kKey1, kValue2);
« no previous file with comments | « no previous file | components/autofill/core/browser/webdata/autocomplete_sync_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698