Remove use of legacy SkFontMgr factories.

content/child/font_warmup_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/font_warmup_win.h"
 
 #include <dwrite.h>
 #include <stdint.h>
 #include <map>
 
@@ skipping 397 matching lines @@
   patched = g_iat_patch_start_service.Patch(
       L"dwrite.dll", service_provider_dll, "StartServiceW", StartServiceWPatch);
   DCHECK(patched == 0);
 
   patched = g_iat_patch_nt_connect_port.Patch(
       L"dwrite.dll", "ntdll.dll", "NtAlpcConnectPort", NtALpcConnectPortPatch);
   DCHECK(patched == 0);
 }
 
 GdiFontPatchData* PatchGdiFontEnumeration(const base::FilePath& path) {
   if (!g_warmup_fontmgr)

[f(malita), 2017/01/09 15:25:34]

What would it take to convert g_warmup_fontmgr to sk_sp<SkFontMgr>?

Are sk_sp<> globals disallowed?

[bungeman-chromium, 2017/01/09 19:15:28]

We've tried this before and had to revert. See
https://bugs.chromium.org/p/chromium/issues/detail?id=665274 . sk_sp<> globals
can't be used because it means registering an exit time destructor which means
an implicit initializer needs to be run in order to register the exit time
destructor. The sizes bot catches this. Skia isn't going to create a sk_sp_leaky
since it doesn't need it. (I believe there is exactly on place that could use
it, and I consider that use legacy.)

-    g_warmup_fontmgr = SkFontMgr_New_DirectWrite();
+    g_warmup_fontmgr = SkFontMgr_New_DirectWrite().release();
   DCHECK(g_warmup_fontmgr);
   return new GdiFontPatchDataImpl(path);
 }
 
 size_t GetEmulatedGdiHandleCountForTesting() {
   return g_fake_gdi_object_factory.Get().GetObjectCount();
 }
 
 void ResetEmulatedGdiHandlesForTesting() {
   g_fake_gdi_object_factory.Get().ResetObjectHandles();
 }
 
-void SetPreSandboxWarmupFontMgrForTesting(SkFontMgr* fontmgr) {
-  g_warmup_fontmgr = fontmgr;
+void SetPreSandboxWarmupFontMgrForTesting(sk_sp<SkFontMgr> fontmgr) {
+  SkSafeUnref(g_warmup_fontmgr);
+  g_warmup_fontmgr = fontmgr.release();
 }
 
 }  // namespace content