Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: pkg/kernel/lib/target/vm.dart

Issue 2618393002: Insert covariance checks in strong mode. (Closed)
Patch Set: Merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/class_hierarchy.dart ('k') | pkg/kernel/lib/transformations/insert_covariance_checks.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/target/vm.dart
diff --git a/pkg/kernel/lib/target/vm.dart b/pkg/kernel/lib/target/vm.dart
index 855857c071fa2352dd75f07a01892f2bce0a898b..58c229dc14f26bf444fa29fba003d5a5de3d2320 100644
--- a/pkg/kernel/lib/target/vm.dart
+++ b/pkg/kernel/lib/target/vm.dart
@@ -4,8 +4,10 @@
library kernel.target.vm;
import '../ast.dart';
+import '../core_types.dart';
import '../transformations/continuation.dart' as cont;
import '../transformations/erasure.dart';
+import '../transformations/insert_covariance_checks.dart';
import '../transformations/insert_type_checks.dart';
import '../transformations/mixin_full_resolution.dart' as mix;
import '../transformations/sanitize_for_vm.dart';
@@ -52,10 +54,16 @@ class VmTarget extends Target {
];
void transformProgram(Program program) {
- new mix.MixinFullResolution().transform(program);
+ var mixins = new mix.MixinFullResolution();
+ mixins.transform(program);
if (strongMode) {
- new InsertTypeChecks().transformProgram(program);
+ var hierarchy = mixins.hierarchy;
+ var coreTypes = new CoreTypes(program);
+ new InsertTypeChecks(hierarchy: hierarchy, coreTypes: coreTypes)
+ .transformProgram(program);
+ new InsertCovarianceChecks(hierarchy: hierarchy, coreTypes: coreTypes)
+ .transformProgram(program);
}
cont.transformProgram(program);
« no previous file with comments | « pkg/kernel/lib/class_hierarchy.dart ('k') | pkg/kernel/lib/transformations/insert_covariance_checks.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698