Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2405)

Unified Diff: ash/common/frame/caption_buttons/frame_caption_button_container_view.cc

Issue 2618383004: Revert of Move more vector icons to respective directories and update code to (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/frame/caption_buttons/frame_caption_button_container_view.cc
diff --git a/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc b/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc
index 3539a04c41bf45a23f8d1d837211fd21477226f5..77f8006780760b3407ecf60e4346883c2ce42fbe 100644
--- a/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc
+++ b/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc
@@ -19,7 +19,7 @@
#include "ui/gfx/canvas.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/point.h"
-#include "ui/gfx/vector_icon_types.h"
+#include "ui/gfx/vector_icons_public.h"
#include "ui/strings/grit/ui_strings.h" // Accessibility names
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
@@ -148,15 +148,14 @@
void FrameCaptionButtonContainerView::SetButtonImage(
CaptionButtonIcon icon,
- const gfx::VectorIcon& icon_definition) {
- button_icon_map_[icon] = &icon_definition;
+ gfx::VectorIconId icon_image_id) {
+ button_icon_id_map_[icon] = icon_image_id;
FrameCaptionButton* buttons[] = {minimize_button_, size_button_,
close_button_};
for (size_t i = 0; i < arraysize(buttons); ++i) {
if (buttons[i]->icon() == icon)
- buttons[i]->SetImage(icon, FrameCaptionButton::ANIMATE_NO,
- icon_definition);
+ buttons[i]->SetImage(icon, FrameCaptionButton::ANIMATE_NO, icon_image_id);
}
}
@@ -300,9 +299,9 @@
FrameCaptionButton::Animate fcb_animate =
(animate == ANIMATE_YES) ? FrameCaptionButton::ANIMATE_YES
: FrameCaptionButton::ANIMATE_NO;
- auto it = button_icon_map_.find(icon);
- if (it != button_icon_map_.end())
- button->SetImage(icon, fcb_animate, *it->second);
+ auto it = button_icon_id_map_.find(icon);
+ if (it != button_icon_id_map_.end())
+ button->SetImage(icon, fcb_animate, it->second);
}
bool FrameCaptionButtonContainerView::ShouldSizeButtonBeVisible() const {

Powered by Google App Engine
This is Rietveld 408576698