third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-disabled-expected.txt - Issue 2618383002: Initial implementation for feature policy - PaymentRequest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-disabled-expected.txt

Issue 2618383002: Initial implementation for feature policy - PaymentRequest (Closed)

Patch Set: Codereview: nit + added link to bug that is blocking payment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-disabled.php ('k') | third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-enabledforall.php » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1

	2

	3 --------

	4 Frame: '<!--framePath //<!--frame0-->-->'

	5 --------

	6 This is a testharness.js-based test.

	7 PASS No iframe may construct PaymentRequest when disabled.

	8 Harness: the test ran to completion.

	9

	10

	11 --------

	12 Frame: '<!--framePath //<!--frame1-->-->'

	13 --------

	14 This is a testharness.js-based test.

	15 PASS No iframe may construct PaymentRequest when disabled.

	16 Harness: the test ran to completion.

	17

	18

	19 --------

	20 Frame: '<!--framePath //<!--frame2-->-->'

	21 --------

	22 This is a testharness.js-based test.

	23 FAIL No iframe may construct PaymentRequest when disabled. assert_equals: expect ed "SecurityError" but got "Error"
	iclelland 2017/01/18 19:31:00 Do you know why this assert is failing? I expected Do you know why this assert is failing? I expected this to fail, since the Feature Policy runtime flag is not enabled in this test, but not for that reason. I'm wondering why the "error" is being thrown. lunalu1 2017/01/19 16:54:08 Error is from assert_unreached. But I have made th Show quoted text On 2017/01/18 19:31:00, iclelland wrote: > Do you know why this assert is failing? I expected this to fail, since the > Feature Policy runtime flag is not enabled in this test, but not for that > reason. I'm wondering why the "error" is being thrown. Error is from assert_unreached. But I have made the error more explicit. Done.
	24 Harness: the test ran to completion.

	25

	26

	27 --------

	28 Frame: '<!--framePath //<!--frame3-->-->'

	29 --------

	30 This is a testharness.js-based test.

	31 FAIL No iframe may construct PaymentRequest when disabled. assert_equals: expect ed "SecurityError" but got "Error"
	iclelland 2017/01/18 19:31:00 Same here Same here lunalu1 2017/01/19 16:54:08 Done. Show quoted text On 2017/01/18 19:31:00, iclelland wrote: > Same here Done.
	32 Harness: the test ran to completion.

	33

OLD	NEW