Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2618343002: Creates the Suggestions UI (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Creates the Suggestions UI This CL creates the Suggestions UI with a Collection View and some cells. For now the cells are not designed by the UI/UX and are more an example than a real implementation. BUG=679369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1028 lines, -0 lines) Patch
A ios/chrome/browser/ui/suggestions/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_article_item.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_article_item.mm View 1 chunk +133 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_data_source.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_data_source.mm View 1 chunk +153 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_expandable_item.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_expandable_item.mm View 1 chunk +278 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_item.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_item.mm View 1 chunk +101 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_view_controller.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/suggestions/suggestions_view_controller.mm View 1 chunk +52 lines, -0 lines 0 comments Download
M ios/showcase/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/showcase/core/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/showcase/core/showcase_model.mm View 1 chunk +5 lines, -0 lines 0 comments Download
A ios/showcase/suggestions/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/showcase/suggestions/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A ios/showcase/suggestions/suggestions_coordinator.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/showcase/suggestions/suggestions_coordinator.mm View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
gambard
PTAL. I did not realized this CL got this big. If you think it is ...
3 years, 11 months ago (2017-01-09 16:33:21 UTC) #4
marq (ping after 24h)
On 2017/01/09 16:33:21, gambard wrote: > PTAL. > I did not realized this CL got ...
3 years, 11 months ago (2017-01-10 10:46:58 UTC) #5
gambard
Closing this as it has been split.
3 years, 11 months ago (2017-01-10 13:08:20 UTC) #6
noyau (Ping after 24h)
3 years, 11 months ago (2017-01-10 13:21:49 UTC) #7
Message was sent while issue was closed. 
On 2017/01/10 13:08:20, gambard wrote:
> Closing this as it has been split.

A quick comment on the naming. I put class names in the doc, and you picked some
other names here. We should fix one or the other :)

Powered by Google App Engine
This is Rietveld 408576698