third_party/WebKit/LayoutTests/svg/animations/script-href-no-animate.html - Issue 2618323002: Block animation of the SVGScriptElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/animations/script-href-no-animate.html

Issue 2618323002: Block animation of the SVGScriptElement (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/animations/resources/set-foo.js ('k') | third_party/WebKit/Source/core/svg/SVGScriptElement.h » ('j') | third_party/WebKit/Source/core/svg/SVGScriptElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>SVGScriptElement.href should not be animatable</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 var foo = 42;

	7

	8 async_test(t => {

	9 window.onload = () => {

	10 var s = document.createElementNS('http://www.w3.org/2000/svg', 'script');

	11 s.onload = t.unreached_func('Should not get a load event');

	12 s.id = 'x';

	13 document.querySelector('svg').appendChild(s);

	14 requestAnimationFrame(_ => {

	15 requestAnimationFrame(t.step_func_done(_ => {
	Mike West 2017/01/09 19:31:19 Why two frames? I'll defer to y'all with regard to Why two frames? I'll defer to y'all with regard to SVG timing, but I'm curious. :) fs 2017/01/10 10:15:16 This is a bit of a frailty with the test I'm afrai Show quoted text On 2017/01/09 at 19:31:19, Mike West (sloooooow) wrote: > Why two frames? I'll defer to y'all with regard to SVG timing, but I'm curious. :) This is a bit of a frailty with the test I'm afraid - it's the "allow X time wherein nothing happens". We need the first to know the animation started (although "after 'load'" works for that too), but that's not enough of a wait since we may need to wait for the script to load and execute. I guess this makes this test a potential "flaky failure (with a high probability)"-type test.
	16 assert_equals(foo, 42);

	17 }));

	18 });

	19 };

	20 });

	21 </script>

	22 <svg>

	23 <rect width="100" height="100" fill="green"/>

	24 <set href="#x" attributeName="href" to="resources/set-foo.js"/>
	Mike West 2017/01/09 19:31:19 Would you mind adding a similar test for `<animate Would you mind adding a similar test for `<animate>` (are there others?) and for `xlink:href`? fs 2017/01/10 10:15:16 I can do that. Show quoted text On 2017/01/09 at 19:31:19, Mike West (sloooooow) wrote: > Would you mind adding a similar test for `<animate>` (are there others?) and for `xlink:href`? I can do that.
	25 </svg>

OLD	NEW