[CUPS] Implement the enterprise icon for printers in Print Preview Dialog.

chrome/browser/resources/print_preview/data/destination.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.exportPath('print_preview');
 
 /**
  * The CDD (Cloud Device Description) describes the capabilities of a print
  * destination.
  *
@@ skipping 243 matching lines @@
     /** Destination is not provisional. */
     NONE: 'NONE',
     /**
      * User has to grant USB access for the destination to its provider.
      * Used for destinations with extension origin.
      */
     NEEDS_USB_PERMISSION: 'NEEDS_USB_PERMISSION'
   };
 
   /**
+   * Special tag that denotes whether the destination is an enterprise policy
+   * controlled printer.
+   * @type {string}
+   * @const
+   * @private
+   */
+  Destination.EnterprisePrinterTag_ = '__cp__cups_enterprise_printer=true';
+
+  /**
    * Enumeration of relative icon URLs for various types of destinations.
    * @enum {string}
    * @private
    */
   Destination.IconUrl_ = {
     CLOUD: 'images/printer.png',
     CLOUD_SHARED: 'images/printer_shared.png',
     LOCAL: 'images/printer.png',
     MOBILE: 'images/mobile.png',
     MOBILE_SHARED: 'images/mobile_shared.png',
     THIRD_PARTY: 'images/third_party.png',
     PDF: 'images/pdf.png',
     DOCS: 'images/google_doc.png',
-    FEDEX: 'images/third_party_fedex.png'
+    FEDEX: 'images/third_party_fedex.png',
+    ENTERPRISE: 'images/business.svg'
   };
 
   Destination.prototype = {
     /** @return {string} ID of the destination. */
     get id() {
       return this.id_;
     },
 
     /** @return {!print_preview.Destination.Type} Type of the destination. */
     get type() {
@@ skipping 194 matching lines @@
     get iconUrl() {
       if (this.id_ == Destination.GooglePromotedId.DOCS) {
         return Destination.IconUrl_.DOCS;
       }
       if (this.id_ == Destination.GooglePromotedId.FEDEX) {
         return Destination.IconUrl_.FEDEX;
       }
       if (this.id_ == Destination.GooglePromotedId.SAVE_AS_PDF) {
         return Destination.IconUrl_.PDF;
       }
+      if (this.isEnterprisePrinter) {
+        return Destination.IconUrl_.ENTERPRISE;
+      }
       if (this.isLocal) {
         return Destination.IconUrl_.LOCAL;
       }
       if (this.type_ == Destination.Type.MOBILE && this.isOwned_) {
         return Destination.IconUrl_.MOBILE;
       }
       if (this.type_ == Destination.Type.MOBILE) {
         return Destination.IconUrl_.MOBILE_SHARED;
       }
       if (this.isOwned_) {
@@ skipping 49 matching lines @@
     get provisionalType() {
       return this.provisionalType_;
     },
 
     /**
      * Whether the destinaion is provisional.
      * @return {boolean}
      */
     get isProvisional() {
       return this.provisionalType_ != Destination.ProvisionalType.NONE;
-    }
+    },
+
+    /**
+     * Whether the printer is enterprise policy controlled printer.
+     * @return {boolean}
+     */
+    get isEnterprisePrinter() {
+      return arrayContains(this.tags_, Destination.EnterprisePrinterTag_);

[dpapad, 2017/01/18 02:56:04]

Is this linear search going to be costly? What is the size of |tags_| and how
often is this function called?

[xdai1, 2017/01/18 18:45:42]

For a single printer, the size of |tags_| equals to the number of the cups
printer's options
(https://cs.chromium.org/chromium/src/build/linux/debian_wheezy_amd64-sysroot/...).
But I don't know how many options a cups printer can have (maybe skau@ knows?) .
This function is called when we initialize the printers list and when the
printer state changes.

[skau, 2017/01/18 20:59:06]

FYI: We expect around 20 printer properties for any given printer.  It could be
more but won't exceed 100.

[dpapad, 2017/01/18 21:09:57]

So if I have hundreds of printers (like in a Google office), is this going to be
a problem? In other words, is there a noticeable slow down in startup (when the
printer list gets initialized)? Can/should |this.tags_| be converted to a native
Set instead, see
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

[skau, 2017/01/18 22:05:40]

xdai@ We should probably make isEnterprise a separate field on the destination. 
Looks like you could extract the value from the options map in
print_preview_handler when converting from a PrintBasicInfo to the dictionary.

[xdai1, 2017/01/19 01:10:17]

I made isEnterprise_ a separate field on the destination object as you
suggested. PrintersToValues() has already extracted the value and saved it in
the dictionary with the key printing::kSettingPrinterOptions (printerOptions).

[xdai1, 2017/01/19 01:10:17]

the format of|this.tags_|
(https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/d...)
is defined to be consistent with cloud print tags format. So it might be better
to leave the format as is for now...

+    },
   };
 
   // Export
   return {
     Destination: Destination,
   };
 });