webrtc-internals: show addIceCandidate when it fails

content/renderer/media/rtc_peer_connection_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/rtc_peer_connection_handler.h"
 
 #include <string.h>
 
 #include <string>
 #include <utility>
@@ skipping 1414 matching lines @@
 
   if (native_candidate) {
     return_value =
         native_peer_connection_->AddIceCandidate(native_candidate.get());
     LOG_IF(ERROR, !return_value) << "Error processing ICE candidate.";
   } else {
     LOG(ERROR) << "Could not create native ICE candidate.";
   }
 
   if (peer_connection_tracker_) {
+    if (!return_value) {
+      // Ensure that addIceCandidate shows up even if there is an error.

[tommi (sloooow) - chröme, 2017/01/09 14:41:17]

reporting this twice intentionally?

[fippo, 2017/01/09 15:09:32]

Yes. The first one (with the true argument) generates the addIceCandidate when
there is an error, the second call (with the actual result) generates the
addIceCandidateOnFailure (when return_value is false).

This sounds rather weird but handling succeeded=false in
https://cs.chromium.org/chromium/src/content/renderer/media/peer_connection_t...
would be equally messy :-/

[hta - Chromium, 2017/01/16 09:12:22]

The original logic seemed to be that you logged either success or error. Why is
it a good thing to log two lines, given that you include all the information
both times?

An alternative rendering would be to change
https://cs.chromium.org/chromium/src/content/renderer/media/peer_connection_t...
from "addIceCandidate" to "addIceCandidate(success)" to indicate that the
log-line is happening after the call has completed.

+      peer_connection_tracker_->TrackAddIceCandidate(
+          this, candidate, PeerConnectionTracker::SOURCE_REMOTE, true);
+    }
     peer_connection_tracker_->TrackAddIceCandidate(
         this, candidate, PeerConnectionTracker::SOURCE_REMOTE, return_value);
   }
   return return_value;
 }
 
 void RTCPeerConnectionHandler::OnaddICECandidateResult(
     const blink::WebRTCVoidRequest& webkit_request, bool result) {
   DCHECK(thread_checker_.CalledOnValidThread());
   TRACE_EVENT0("webrtc", "RTCPeerConnectionHandler::OnaddICECandidateResult");
@@ skipping 500 matching lines @@
 }
 
 void RTCPeerConnectionHandler::ResetUMAStats() {
   DCHECK(thread_checker_.CalledOnValidThread());
   num_local_candidates_ipv6_ = 0;
   num_local_candidates_ipv4_ = 0;
   ice_connection_checking_start_ = base::TimeTicks();
   memset(ice_state_seen_, 0, sizeof(ice_state_seen_));
 }
 }  // namespace content