Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: components/ntp_snippets/mock_content_suggestions_provider.h

Issue 2618243004: Add a unit test for the BookmarkSuggestionsProvider. (Closed)
Patch Set: renamed MockProvider and updated tests comments about expected behavior Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/mock_content_suggestions_provider.h
diff --git a/components/ntp_snippets/mock_content_suggestions_provider.h b/components/ntp_snippets/mock_content_suggestions_provider.h
new file mode 100644
index 0000000000000000000000000000000000000000..17cfeadfb81ec888508be6a197856a6a4c123868
--- /dev/null
+++ b/components/ntp_snippets/mock_content_suggestions_provider.h
@@ -0,0 +1,72 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_SNIPPETS_MOCK_CONTENT_SUGGESTIONS_PROVIDER_H_
+#define COMPONENTS_NTP_SNIPPETS_MOCK_CONTENT_SUGGESTIONS_PROVIDER_H_
+
+#include <map>
+#include <set>
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "components/ntp_snippets/content_suggestions_provider.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+namespace ntp_snippets {
+
+// TODO(treib): This is a weird combination of a mock and a fake. Fix this.
+class MockContentSuggestionsProvider : public ContentSuggestionsProvider {
+ public:
+ MockContentSuggestionsProvider(
+ Observer* observer,
+ const std::vector<Category>& provided_categories);
+ ~MockContentSuggestionsProvider();
+
+ void SetProvidedCategories(const std::vector<Category>& provided_categories);
+
+ // Returns the status for |category|. The initial status in
+ // CatgoryStatus::AVAILABLE. Will be updated on FireCategoryStatusChanged
+ // events.
+ CategoryStatus GetCategoryStatus(Category category) override;
+
+ // Returns a hard-coded category info object.
+ CategoryInfo GetCategoryInfo(Category category) override;
+
+ // Forwards events to the underlying oberservers.
+ // TODO(tschumann): This functionality does not belong here. Whoever injected
+ // the observer into the constructor can as well notify the observer itself.
+ void FireSuggestionsChanged(Category category,
+ std::vector<ContentSuggestion> suggestions);
+ void FireCategoryStatusChanged(Category category, CategoryStatus new_status);
+ void FireCategoryStatusChangedWithCurrentStatus(Category category);
+ void FireSuggestionInvalidated(const ContentSuggestion::ID& suggestion_id);
+
+ MOCK_METHOD3(ClearHistory,
+ void(base::Time begin,
+ base::Time end,
+ const base::Callback<bool(const GURL& url)>& filter));
+ MOCK_METHOD3(Fetch,
+ void(const Category&,
+ const std::set<std::string>&,
+ const FetchDoneCallback&));
+ MOCK_METHOD1(ClearCachedSuggestions, void(Category category));
+ MOCK_METHOD2(GetDismissedSuggestionsForDebugging,
+ void(Category category,
+ const DismissedSuggestionsCallback& callback));
+ MOCK_METHOD1(ClearDismissedSuggestionsForDebugging, void(Category category));
+ MOCK_METHOD1(DismissSuggestion,
+ void(const ContentSuggestion::ID& suggestion_id));
+ MOCK_METHOD2(FetchSuggestionImage,
+ void(const ContentSuggestion::ID& suggestion_id,
+ const ImageFetchedCallback& callback));
+
+ private:
+ std::vector<Category> provided_categories_;
+ std::map<int, CategoryStatus> statuses_;
+};
+
+} // namespace ntp_snippets
+
+#endif // COMPONENTS_NTP_SNIPPETS_MOCK_CONTENT_SUGGESTIONS_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698