Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

Issue 2618243004: Add a unit test for the BookmarkSuggestionsProvider. (Closed)
Patch Set: renamed MockProvider and updated tests comments about expected behavior Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ntp_snippets/mock_content_suggestions_provider.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/remote/remote_suggestions_provider_impl.h" 5 #include "components/ntp_snippets/remote/remote_suggestions_provider_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 13 matching lines...) Expand all
24 #include "base/threading/thread_task_runner_handle.h" 24 #include "base/threading/thread_task_runner_handle.h"
25 #include "base/time/time.h" 25 #include "base/time/time.h"
26 #include "components/image_fetcher/image_decoder.h" 26 #include "components/image_fetcher/image_decoder.h"
27 #include "components/image_fetcher/image_fetcher.h" 27 #include "components/image_fetcher/image_fetcher.h"
28 #include "components/image_fetcher/image_fetcher_delegate.h" 28 #include "components/image_fetcher/image_fetcher_delegate.h"
29 #include "components/ntp_snippets/category.h" 29 #include "components/ntp_snippets/category.h"
30 #include "components/ntp_snippets/category_info.h" 30 #include "components/ntp_snippets/category_info.h"
31 #include "components/ntp_snippets/category_rankers/category_ranker.h" 31 #include "components/ntp_snippets/category_rankers/category_ranker.h"
32 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h" 32 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h"
33 #include "components/ntp_snippets/category_rankers/mock_category_ranker.h" 33 #include "components/ntp_snippets/category_rankers/mock_category_ranker.h"
34 #include "components/ntp_snippets/fake_content_suggestions_provider_observer.h"
34 #include "components/ntp_snippets/ntp_snippets_constants.h" 35 #include "components/ntp_snippets/ntp_snippets_constants.h"
35 #include "components/ntp_snippets/pref_names.h" 36 #include "components/ntp_snippets/pref_names.h"
36 #include "components/ntp_snippets/remote/ntp_snippet.h" 37 #include "components/ntp_snippets/remote/ntp_snippet.h"
37 #include "components/ntp_snippets/remote/ntp_snippets_fetcher.h" 38 #include "components/ntp_snippets/remote/ntp_snippets_fetcher.h"
38 #include "components/ntp_snippets/remote/persistent_scheduler.h" 39 #include "components/ntp_snippets/remote/persistent_scheduler.h"
39 #include "components/ntp_snippets/remote/remote_suggestions_database.h" 40 #include "components/ntp_snippets/remote/remote_suggestions_database.h"
40 #include "components/ntp_snippets/remote/test_utils.h" 41 #include "components/ntp_snippets/remote/test_utils.h"
41 #include "components/ntp_snippets/user_classifier.h" 42 #include "components/ntp_snippets/user_classifier.h"
42 #include "components/prefs/testing_pref_service.h" 43 #include "components/prefs/testing_pref_service.h"
43 #include "components/signin/core/browser/fake_profile_oauth2_token_service.h" 44 #include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 public: 337 public:
337 MOCK_METHOD1(SetImageFetcherDelegate, void(ImageFetcherDelegate*)); 338 MOCK_METHOD1(SetImageFetcherDelegate, void(ImageFetcherDelegate*));
338 MOCK_METHOD1(SetDataUseServiceName, void(DataUseServiceName)); 339 MOCK_METHOD1(SetDataUseServiceName, void(DataUseServiceName));
339 MOCK_METHOD3( 340 MOCK_METHOD3(
340 StartOrQueueNetworkRequest, 341 StartOrQueueNetworkRequest,
341 void(const std::string&, 342 void(const std::string&,
342 const GURL&, 343 const GURL&,
343 base::Callback<void(const std::string&, const gfx::Image&)>)); 344 base::Callback<void(const std::string&, const gfx::Image&)>));
344 }; 345 };
345 346
346 class FakeContentSuggestionsProviderObserver
347 : public ContentSuggestionsProvider::Observer {
348 public:
349 FakeContentSuggestionsProviderObserver() = default;
350
351 void OnNewSuggestions(ContentSuggestionsProvider* provider,
352 Category category,
353 std::vector<ContentSuggestion> suggestions) override {
354 suggestions_[category] = std::move(suggestions);
355 }
356
357 void OnCategoryStatusChanged(ContentSuggestionsProvider* provider,
358 Category category,
359 CategoryStatus new_status) override {
360 statuses_[category] = new_status;
361 }
362
363 void OnSuggestionInvalidated(
364 ContentSuggestionsProvider* provider,
365 const ContentSuggestion::ID& suggestion_id) override {}
366
367 const std::map<Category, CategoryStatus, Category::CompareByID>& statuses()
368 const {
369 return statuses_;
370 }
371
372 CategoryStatus StatusForCategory(Category category) const {
373 auto it = statuses_.find(category);
374 EXPECT_THAT(it, Not(Eq(statuses_.end())));
375 return it->second;
376 }
377
378 const std::vector<ContentSuggestion>& SuggestionsForCategory(
379 Category category) {
380 return suggestions_[category];
381 }
382
383 private:
384 std::map<Category, CategoryStatus, Category::CompareByID> statuses_;
385 std::map<Category, std::vector<ContentSuggestion>, Category::CompareByID>
386 suggestions_;
387
388 DISALLOW_COPY_AND_ASSIGN(FakeContentSuggestionsProviderObserver);
389 };
390
391 class FakeImageDecoder : public image_fetcher::ImageDecoder { 347 class FakeImageDecoder : public image_fetcher::ImageDecoder {
392 public: 348 public:
393 FakeImageDecoder() {} 349 FakeImageDecoder() {}
394 ~FakeImageDecoder() override = default; 350 ~FakeImageDecoder() override = default;
395 void DecodeImage( 351 void DecodeImage(
396 const std::string& image_data, 352 const std::string& image_data,
397 const image_fetcher::ImageDecodedCallback& callback) override { 353 const image_fetcher::ImageDecodedCallback& callback) override {
398 callback.Run(decoded_image_); 354 callback.Run(decoded_image_);
399 } 355 }
400 356
(...skipping 1454 matching lines...) Expand 10 before | Expand all | Expand 10 after
1855 RemoteSuggestionsProvider::ProviderStatus)>::Call, 1811 RemoteSuggestionsProvider::ProviderStatus)>::Call,
1856 base::Unretained(&status_callback)))); 1812 base::Unretained(&status_callback))));
1857 1813
1858 // Should be called when becoming disabled. 1814 // Should be called when becoming disabled.
1859 EXPECT_CALL(status_callback, 1815 EXPECT_CALL(status_callback,
1860 Call(RemoteSuggestionsProvider::ProviderStatus::INACTIVE)); 1816 Call(RemoteSuggestionsProvider::ProviderStatus::INACTIVE));
1861 service->EnterState(RemoteSuggestionsProviderImpl::State::DISABLED); 1817 service->EnterState(RemoteSuggestionsProviderImpl::State::DISABLED);
1862 } 1818 }
1863 1819
1864 } // namespace ntp_snippets 1820 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/mock_content_suggestions_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698