Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2618243002: Fix the rest of the completion tests with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the rest of the completion tests with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e80a54e432fb2df5850a6b70cb221af354d020e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart View 3 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scheglov
3 years, 11 months ago (2017-01-08 20:55:08 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-08 22:22:06 UTC) #3
scheglov
3 years, 11 months ago (2017-01-08 23:16:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e80a54e432fb2df5850a6b70cb221af354d020e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698