Issue 261823002: Add the picture element

Issue 261823002: Add the picture element (Closed)

Created:
6 years, 7 months ago by Yoav Weiss

Modified:
6 years, 7 months ago

Reviewers:
eseidel

CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add the picture element Add the DOM part of the picture element, without actually using it for anything useful just yet. BUG=368830 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173575

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Removed virtual destructor #

Patch Set 4 : Added HTMLPictureElement to expected global constructors #

Total comments: 1

Patch Set 5 : typo #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -3 lines)			Patch
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/core.gypi	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
A	Source/core/html/HTMLPictureElement.h	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
A	Source/core/html/HTMLPictureElement.cpp	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A +	Source/core/html/HTMLPictureElement.idl	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLTagNames.in	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/261823002/diff/60001/Source/core/html/HTMLPictureElement.idl File Source/core/html/HTMLPictureElement.idl (right): https://codereview.chromium.org/261823002/diff/60001/Source/core/html/HTMLPictureElement.idl#newcode5 Source/core/html/HTMLPictureElement.idl:5: // http://picture.responsiveimags.org Missing an e?

6 years, 7 months ago (2014-05-07 21:44:33 UTC) #2

Yoav Weiss

On 2014/05/07 21:44:33, eseidel wrote: > lgtm > > https://codereview.chromium.org/261823002/diff/60001/Source/core/html/HTMLPictureElement.idl > File Source/core/html/HTMLPictureElement.idl (right): > ...

6 years, 7 months ago (2014-05-07 21:48:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/261823002/80001

6 years, 7 months ago (2014-05-07 21:49:23 UTC) #5

Message was sent while issue was closed.

Change committed as 173575

Expand Messages | Collapse Messages